UBERF-12966: Send messages from Gmail threads #9657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13042 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ability to send messages from Gmail threads as part of UBERF-12966. The feature allows outgoing Gmail messages to be sent when messages are created in Huly threads that are connected to Gmail channels.
Key changes include:
- Added message sending capabilities from Gmail threads with proper header identification
- Implemented markdown to HTML conversion for email formatting
- Added queue consumer to listen for new message events and trigger Gmail sending
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| services/mail/mail-common/src/utils.ts | Added utility functions for message metadata, sync detection, and reply subject generation |
| services/mail/mail-common/src/types.ts | Extended types to support message metadata and communication domain |
| services/mail/mail-common/src/txHandler.ts | Added transaction handler to convert platform transactions to message events |
| services/mail/mail-common/src/send.ts | Added placeholder functions for message sending logic |
| services/mail/mail-common/src/person.ts | Enhanced person cache with email lookup by social ID |
| services/mail/mail-common/src/message.ts | Updated message creation to include extra metadata |
| services/mail/mail-common/src/md.ts | Added markdown to HTML conversion utilities |
| services/mail/mail-common/src/index.ts | Exported new modules |
| services/mail/mail-common/src/tests/md.test.ts | Added comprehensive tests for markdown conversion |
| services/mail/mail-common/package.json | Added markdown-it dependency |
| services/gmail/pod-gmail/src/workspaceClient.ts | Added message handling delegation to Gmail clients |
| services/gmail/pod-gmail/src/utils.ts | Added Gmail search query builder for message deduplication |
| services/gmail/pod-gmail/src/types.ts | Added Gmail-specific constants and headers |
| services/gmail/pod-gmail/src/message/v2/send.ts | Implemented Gmail message sending with proper headers and formatting |
| services/gmail/pod-gmail/src/message/v2/message.ts | Enhanced message processing to skip Huly-sent messages |
| services/gmail/pod-gmail/src/gmailController.ts | Added queue consumer for handling new message events |
| services/gmail/pod-gmail/src/gmail.ts | Implemented core Gmail message sending logic with deduplication |
| services/gmail/pod-gmail/src/client.ts | Added communication client creation utilities |
| services/gmail/pod-gmail/package.json | Added required dependencies |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Signed-off-by: Artem Savchenko <armisav@gmail.com>
…cter sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
BykhovDenis
approved these changes
Aug 11, 2025
aonnikov
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.