Refactor device management in the office #9656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Office's own logic for device management. Now the Recorder and the Office use common logic and UI components from the Media plugin Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13041 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors device management in the office by extracting common functionality from the Love plugin to the Media plugin. The change consolidates device management logic and UI components to avoid duplication between the Recorder and Office features.
- Extracted device management components to Media plugin for reuse
- Refactored Love plugin to use common Media components instead of duplicated code
- Updated device state management to use shared utilities from Media plugin
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/media/src/plugin.ts | Added component exports for device selector popups |
| plugins/media-resources/src/utils.ts | Added toggle functions for camera and microphone state |
| plugins/media-resources/src/index.ts | Exported new device selector components |
| plugins/media-resources/src/components/MicStateButton.svelte | Refactored to use shared toggle function |
| plugins/media-resources/src/components/CamStateButton.svelte | Refactored to use shared toggle function |
| plugins/love-resources/src/utils.ts | Updated to use Media plugin's device management functions |
| plugins/love-resources/src/components/meeting/MicSettingPopup.svelte | New component using Media plugin components |
| plugins/love-resources/src/components/meeting/CamSettingPopup.svelte | New component using Media plugin components |
| plugins/love-resources/src/components/RoomPopup.svelte | Updated to use shared toggle functions and new popup components |
| plugins/love-resources/src/components/MicSettingPopup.svelte | Removed duplicate component |
| plugins/love-resources/src/components/ControlBar.svelte | Updated to use shared toggle functions and new popup components |
| plugins/love-resources/src/components/CamSettingPopup.svelte | Removed duplicate component |
plugins/love-resources/src/components/meeting/CamSettingPopup.svelte
Outdated
Show resolved
Hide resolved
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
aonnikov
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Office's own logic for device management. Now the Recorder and the Office use common logic and UI components from the Media plugin