Fix gmail disconnect error #9649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13030 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors HTTP request handling across multiple integration plugins by extracting duplicate request logic into a centralized utility function. This improves code maintainability and fixes inconsistent error handling for Gmail integration disconnections.
- Centralizes HTTP request logic in a new shared utility function
- Removes duplicate request implementations across telegram, gmail, and calendar plugins
- Adds improved response handling for empty/non-JSON responses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/integration-client/src/request.ts | New centralized HTTP request utility with comprehensive error handling |
| packages/integration-client/src/index.ts | Exports the new request utility |
| plugins/telegram-resources/src/api.ts | Replaces local request implementation with shared utility |
| plugins/gmail-resources/src/api.ts | Replaces local request implementation with shared utility |
| plugins/calendar-resources/src/api.ts | Replaces local request implementation with shared utility |
| plugins/setting-resources/src/components/integrations/Integrations.svelte | Removes debug console.log statements |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
BykhovDenis
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.