analytics: add IP headers collection for geo debugging and session tracking #9648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SasLord
commented
Aug 6, 2025
- Add getAllPossibleIps() function to collect 15+ IP header variants for debugging geolocation issues in Kubernetes environments
- Include all collected IPs (ip_connection, ip_x_forwarded_for_*, ip_cf_connecting_ip, etc.) in PostHog events
- Add SessionManager class for proper session/pageview tracking with UUID generation
…acking Signed-off-by: Alexander Platov <alexander.platov@hardcoreeng.com>
|
Connected to Huly®: UBERF-13013 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive IP collection and session tracking capabilities to the analytics system. The changes focus on improving geolocation debugging in Kubernetes environments and implementing proper session/pageview tracking.
- Enhanced IP address collection with 15+ header variants for debugging geolocation issues
- Implemented SessionManager class for proper session and pageview tracking with UUID generation
- Fixed navigation event timing to ensure proper URL state before analytics capture
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
services/analytics-collector/pod-analytics-collector/src/server.ts |
Integrates getAllPossibleIps function to collect all IP headers in PostHog events |
services/analytics-collector/pod-analytics-collector/src/geoip.ts |
Adds comprehensive IP collection function and simplifies getClientIp logic |
packages/ui/src/location.ts |
Moves Analytics.navigate call after state update to ensure proper timing |
packages/analytics-providers/src/utils.ts |
Implements SessionManager class and enhances event metadata collection |
packages/analytics-providers/src/analyticsCollector.ts |
Adds URL change trigger for navigation tracking |
BykhovDenis
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.