Traceability matrix preparation #10286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
|
Connected to Huly®: UBERF-14401 |
| part = part.slice(0, -1) | ||
| } | ||
| if (curr[part] === undefined) { | ||
| curr[part] = {} |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
The best way to fix this issue is to prevent malicious keys such as "__proto__", "constructor", and "prototype" from ever being used as object property names in the intermediate data structure. This can be achieved by adding a check before assignment for each property name, skipping or rejecting any that could be used for prototype pollution. A robust implementation should use a helper function to perform this check and only allow safe keys.
Specifically:
- Edit the method
buildaAssociationinplugins/view-resources/src/utils.tsto prevent property assignment ifpartequals"__proto__","constructor", or"prototype"(or other dangerous keys). - The check should be applied on every iteration in the
for ... of partsloop, wherecurr[part]is being accessed and assigned. - Optionally, you can define a small utility function or a set in the file to keep this logic clean.
- You do not need to change the data structure to a Map—the risk is managed as long as dangerous keys cannot enter as properties.
- Only modify the code in the region shown; do not change other logic.
Suggested changeset
1
plugins/view-resources/src/utils.ts
| @@ -518,6 +518,12 @@ | ||
| return convertAssociationsRecord(record) | ||
| } | ||
|
|
||
| // Prevent prototype pollution by skipping dangerous property names | ||
| const dangerousKeys = new Set(['__proto__', 'constructor', 'prototype']); | ||
| function isSafeKey(key: string): boolean { | ||
| return !dangerousKeys.has(key); | ||
| } | ||
|
|
||
| function buildaAssociation (stringKey: string, record: Record<string, any>): void { | ||
| const parts = stringKey.split('$associations.').filter((it) => it.length > 0) | ||
| let curr = record | ||
| @@ -525,10 +531,11 @@ | ||
| if (part.endsWith('.')) { | ||
| part = part.slice(0, -1) | ||
| } | ||
| if (!isSafeKey(part)) continue; | ||
| if (curr[part] === undefined) { | ||
| curr[part] = {} | ||
| } | ||
| curr = record[part] | ||
| curr = curr[part] | ||
| } | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
ArtyomSavchenko
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.