Skip to content

Use navigation by types instead of spaces #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haiodo merged 3 commits into from
Oct 14, 2025
Merged

Use navigation by types instead of spaces #10083

haiodo merged 3 commits into from
Oct 14, 2025

Conversation

@ArtyomSavchenko
Copy link
Member

@ArtyomSavchenko ArtyomSavchenko commented Oct 14, 2025 •
edited
Loading

Screenshot 2025-10-14 at 13 24 40

@ArtyomSavchenko
Use navigation by types instead of spaces
668537e 
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Copilot AI reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements navigation by types instead of spaces for the card plugin, shifting from space-based navigation to type-based navigation using card types (MasterTag).

  • Adds GroupsNavModel interface to support type-based navigation structure
  • Creates new TypesNavigator component to display card types hierarchically
  • Updates routing logic to handle type-based URLs (/card/type/{typeId})

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
plugins/workbench/src/types.ts Defines new GroupsNavModel interface and extends navigation models
plugins/workbench-resources/src/components/Workbench.svelte Adds support for finding specials within groups
plugins/workbench-resources/src/components/Navigator.svelte Renders group components in navigation
plugins/card-resources/src/utils.ts Updates routing logic to handle type navigation
plugins/card-resources/src/plugin.ts Adds TypesNavigator component export
plugins/card-resources/src/index.ts Registers TypesNavigator component
plugins/card-resources/src/components/navigator/TypesNavigator.svelte New component for type-based navigation
plugins/card-resources/src/components/navigator/TagHierarchy.svelte Updates to support both space and type selection
plugins/card-resources/src/components/Main.svelte Updates to handle type-based navigation
plugins/card-resources/src/components/CardFeedView.svelte Improves space handling for type-based views
models/card/src/index.ts Configures navigation model to use groups instead of spaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ArtyomSavchenko and others added 2 commits October 14, 2025 16:37
@ArtyomSavchenko
Build type path
038beca 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Artyom Savchenko <armisav@gmail.com>
@ArtyomSavchenko
Fix formatting
8a49d89 
Signed-off-by: Artem Savchenko <armisav@gmail.com>
@ArtyomSavchenko ArtyomSavchenko marked this pull request as ready for review October 14, 2025 10:31
@kristina-fefelova
Copy link
Member

kristina-fefelova commented Oct 14, 2025

Do we need top-level section types ?

@ArtyomSavchenko
Copy link
Member Author

ArtyomSavchenko commented Oct 14, 2025

Do we need top-level section types ?

Do you mean add a section for types next to All Cards and Spaces?
I think this would be useful
In my opinion, it would also be good to add the ability to add a new type from there without going into the settings

@kristina-fefelova
Copy link
Member

kristina-fefelova commented Oct 14, 2025

Do we need top-level section types ?

Do you mean add a section for types next to All Cards and Spaces? I think this would be useful In my opinion, it would also be good to add the ability to add a new type from there without going into the settings

I mean, what's the point of this types section? Does it do anything other than create additional nesting?

Screenshot 2025-10-14 at 14 54 38

IMHO: there's no need to create types here, it's not a common operation.

@ArtyomSavchenko
Copy link
Member Author

ArtyomSavchenko commented Oct 14, 2025 •
edited
Loading

Do we need top-level section types ?

Do you mean add a section for types next to All Cards and Spaces? I think this would be useful In my opinion, it would also be good to add the ability to add a new type from there without going into the settings

I mean, what's the point of this types section? Does it do anything other than create additional nesting?

Screenshot 2025-10-14 at 14 54 38 IMHO: there's no need to create types here, it's not a common operation.

I think the types look worse without the section.
We could consider making the section non-collapsible or displaying the heading separately, but I don't know if it's worth the time.
Screenshot 2025-10-14 at 18 30 34

@huly-github-staging
Copy link

huly-github-staging bot commented Oct 14, 2025

Connected to Huly®: UBERF-13924

@haiodo haiodo merged commit 206880f into develop Oct 14, 2025
15 checks passed
@haiodo haiodo deleted the types-navigator branch October 14, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

@kristina-fefelova kristina-fefelova Awaiting requested review from kristina-fefelova

@aonnikov aonnikov Awaiting requested review from aonnikov

+1 more reviewer

@haiodo haiodo haiodo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtyomSavchenko @kristina-fefelova @haiodo