Fix admin integrations #10076
Merged
Fix admin integrations #10076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
lexiv0re
reviewed
Oct 14, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes admin integration access by replacing the special admin token handling with a proper service-based approach. The changes ensure that admin operations use the 'admin' service designation instead of a generic admin flag.
- Replaced admin-specific token handling with service-based authentication
- Updated integration test utilities to use the new service account client approach
- Added 'admin' as a recognized service in the integration services list
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ws-tests/api-tests/src/tests/rest.test.ts | Updated admin token generation to include service designation |
| tests/sanity/tests/integrations.spec.ts | Replaced admin account client with service account client for GitHub |
| tests/sanity/tests/API/AccountClient.ts | Added new service account client function for service-based authentication |
| tests/sanity/package.json | Added server-token dependency for token generation |
| server/account/src/utils.ts | Removed admin bypass logic and added 'admin' to integration services |
| server/account/src/serviceOperations.ts | Added admin check bypass for social ID operations |
| server/account/src/operations.ts | Added 'admin' service to allowed services lists |
| server/account/src/tests/utils.test.ts | Removed test for deprecated admin bypass functionality |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
lexiv0re
reviewed
Oct 14, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
lexiv0re
approved these changes
Oct 14, 2025
|
Connected to Huly®: UBERF-13928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.