fix: revert simplification of stride calculation in LogLocator#3
Merged
II-Day-II merged 6 commits intoissue/24092from Mar 7, 2023
Merged
fix: revert simplification of stride calculation in LogLocator#3II-Day-II merged 6 commits intoissue/24092from
II-Day-II merged 6 commits intoissue/24092from
Conversation
Collaborator
Author
|
None of the old tests seem to have broken either, now all that's needed is some cleanup and this should be PR:able |
conform to more pythonic style
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting the stride calculation to what it was before this commit
now passes the new tests.