feat: add streaming mode for request body file #787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d0c27d to
86df293
Compare
Contributor
reneleonhardt
left a comment
There was a problem hiding this comment.
Keep in mind, I'm no maintainer, they may have different opinions if they would review your feature.
| version: http::Version::HTTP_11, | ||
| headers: http::header::HeaderMap::new(), | ||
| body: Bytes::new(), | ||
| body: Option::from(Bytes::new()), |
Contributor
There was a problem hiding this comment.
Some(Bytes::new()) would be easier to read, but what does Some empty body mean as long as nothing has been received yet?
Suggested change
| body: Option::from(Bytes::new()), | |
| body: None, |
| pub headers: HeaderMap, | ||
| pub body: Bytes, | ||
| pub body: Option<Bytes>, | ||
| pub body_lines_reader: Option<Arc<Mutex<LineReader>>>, |
Contributor
There was a problem hiding this comment.
Are really multiple threads mutating the reader at the same time?
Otherwise
Suggested change
| pub body_lines_reader: Option<Arc<Mutex<LineReader>>>, | |
| pub body_lines_reader: Option<Arc<LineReader>>, |
should be enough, this seems sequential access only to me.
Without threads even Option<LineReader> should be working fine.
| HTTP request body. | ||
| -D <BODY_PATH> | ||
| HTTP request body from file. | ||
| -Z <BODY_PATH_LINES> |
Contributor
There was a problem hiding this comment.
I would feel better if all those conflicts/exclusions would be explained here (and in the actual help of course).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #729