Skip to content

chore: update dependencies #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hatoo merged 2 commits into from
Sep 6, 2025
Merged

chore: update dependencies #786

hatoo merged 2 commits into from
Sep 6, 2025
+374 −363

Conversation

@reneleonhardt
Copy link
Contributor

@reneleonhardt reneleonhardt commented Sep 6, 2025 •
edited
Loading

Chores

  • Update JSON schema to draft 2020-12 and require integer keys in statusCodeDistribution
  • Update cargo-pgo to latest stable
  • Improve and update docker build to latest stable

@reneleonhardt
Copy link
Contributor Author

reneleonhardt commented Sep 6, 2025 •
edited
Loading

I had no problem building macos-arm64-pgo locally with act, but all commented pgo builds still fail remotely.

linux-arm64-pgo:

tikv-jemalloc-sys@0.6.0+5.3.0-1:
background_threads_runtime_support not supported for aarch64-unknown-linux-musl

bun run on macos: https://github.com/hatoo/oha/actions/runs/17514046082/job/49749313355?pr=786

Running `target/x86_64-apple-darwin/pgo/oha -z 3m -c 900 --no-tui 'http://localhost:8888'`
Cargo finished with an error (-1)
ShellError: Failed with exit code 1

Can aarch64-pc-windows-msvc be added?

Can the PGO coverage be increased and the deadline decreased?

[WARN  cargo_pgo::pgo::optimize] PGO profile data was not found for 17 functions.

@reneleonhardt reneleonhardt force-pushed the chore/update-dependencies branch 4 times, most recently from 92cce82 to b7e9132 Compare September 6, 2025 11:53
@reneleonhardt reneleonhardt force-pushed the chore/update-dependencies branch from b7e9132 to 47cafb6 Compare September 6, 2025 12:07
hatoo
hatoo requested changes Sep 6, 2025
View reviewed changes
Copy link
Owner

@hatoo hatoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.github/workflows/release-pgo.yml Outdated
components: llvm-tools-preview
- uses: Swatinem/rust-cache@v2
- run: cargo install cargo-pgo --version 0.2.8
- run: cargo install cargo-pgo
Copy link
Owner

@hatoo hatoo Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you lock the version of cargo-pgo?

Copy link
Contributor Author

@reneleonhardt reneleonhardt Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but then I will not update it anymore.

Official workflow example:
https://github.com/Kobzol/cargo-pgo/blob/main/ci/pgo.yml

run: cargo install cargo-pgo  # install latest release

Copy link
Owner

@hatoo hatoo Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kobzol/cargo-pgo#53

It had actually happened that breaking changes on cargo-pgo breaks CI.
So, I want to update cargo-pgo manually.

@hatoo
Copy link
Owner

hatoo commented Sep 6, 2025

I don't have much interest on PGO builds now.

Can aarch64-pc-windows-msvc be added?

I don't think there are many people who want to support aarch64-pc-windows-msvc but if you add it, I'll merge happily.

Can the PGO coverage be increased and the deadline decreased?

Yes, PGO workload is needed to be polished. PRs are welcome.

@hatoo hatoo merged commit ebaa0a2 into hatoo:master Sep 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hatoo hatoo hatoo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reneleonhardt @hatoo