feat: add curl-compatible multipart form data support (-F option) #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive support for HTTP multipart form data submission using the -F/--form option, fully compatible with curl's form data syntax. Features: - Support for text fields: -F 'name=value' - File uploads with filename: -F 'file=@path/to/file' - File uploads without filename: -F 'file=<path/to/file' - Custom content types: -F 'field=data;type=text/plain' - Custom filenames: -F 'field=data;filename=custom.txt' - Proper multipart/form-data boundary generation - Comprehensive test coverage for all form data scenarios Implementation includes: - New curl_compat module with Form and FormPart structures - RFC-compliant multipart body generation - Integration with existing CLI argument parsing - Mutual exclusion with -d/-D body options - Full compatibility with curl's -F syntax and behavior This enables oha to perform load testing on endpoints that require multipart form data, such as file upload APIs and forms with mixed content types.
Contributor
|
Awesome feature, thank you! The description mentions What's still needed for full compatibility, are there unit tests covering it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive support for HTTP multipart form data submission using the -F/--form option, fully compatible with curl's form data syntax.
Features:
Implementation includes:
This enables oha to perform load testing on endpoints that require multipart form data, such as file upload APIs and forms with mixed content types.
This PR partially resolve #754. It's not fill compatible to curl yet