Allow appending to database if oha table has already been created #742
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Runs are separated by start time
hatoo
approved these changes
May 30, 2025
Owner
|
I think the risk of collision is negligible even if using second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #734
This PR goes the route I mentioned of just automatically appending to the DB without failing if the table already exists.
Namely we use
instead of
Runs are separated by start time of the run which is accurate to the second. I would prefer milliseconds to reduce risk of a collision but
.as_millis()returnsu128which does not implementToSql. If there is a better alternative suggested I can implement that.