Add support for fractional QPS values #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Updated the commit to fix a clippy error |
hatoo
requested changes
Apr 2, 2025
Owner
hatoo
left a comment
There was a problem hiding this comment.
Thank you!
I added a review. Others are good.
src/client.rs
Outdated
Comment on lines
1110
to
1112
| let sleep_ms = i as f64 * 1000f64 / qps; | ||
| tokio::time::sleep_until( | ||
| (start + i as u32 * std::time::Duration::from_secs(1) / qps as u32).into(), | ||
| (start + std::time::Duration::from_millis(sleep_ms as u64)).into(), |
Owner
There was a problem hiding this comment.
Please use std::time::Duration::from_secs_f64 instead.
Author
There was a problem hiding this comment.
Good idea, I've made the change
This adds support for fractional QPS values (QPS is no longer required to be an integer). There is a new test using a fractional 1.75 QPS value, the test would fail if the QPS value would be treated as integer. There's also a small refactoring in the tests to create a new `test_request_count` function to enable using the same function in all of the query limit tests.
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for fractional QPS values (QPS is no longer required to be an integer). The sleep time calculation between requests has been changed to use milliseconds. There is a new test using a fractional 1.75 QPS value, the test would fail if the QPS value would be treated as integer.
There's also a small refactoring in the tests to create a new
test_request_countfunction to enable using the same function in all of the query limit tests.