fix: improve error handling for URLs without scheme #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace unwrap() with some error handling - Print user-friendly error message - Set exit code on failure This change makes the tool more user-friendly by providing error messages instead of panicking.
hatoo
requested changes
Jan 25, 2025
Owner
hatoo
left a comment
There was a problem hiding this comment.
Nice catch!
I added a small review.
Thank you.
Owner
|
👍 |
|
nas khdama lahoma barik hhh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using oha, I found that it panics when given a URL without a scheme (e.g., localhost:4221 instead of http://localhost:4221).
Instead of a friendly error message, we get this panic:
Proposed Change
I tried to make this a bit more user-friendly by: