Added style and colors to the printer output, small adjustment to monitor colors #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatoo
requested changes
Aug 26, 2023
Owner
hatoo
left a comment
There was a problem hiding this comment.
Thank you!
I left just one review!
Owner
|
Clippy fail is OK. It's false positive. |
Contributor
Author
|
Just pushed the |
Owner
This is really great, could you update |
Contributor
Author
|
Manual testing looked fine. The |
hatoo
approved these changes
Aug 26, 2023
Owner
|
LGTM. Thank you! 🎉 |
Contributor
Author
No problem, thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st pass at adding style and colors to the printer view. Related to issue: #64
I've tried to abstract the style and colors configuration into the
StyleSchemestruct.I also made a minor adjustment to the monitor colors to make it consistent with the printer colors.
Code respects the
--disable-colorflag (but maintains the style changes, e.g. bold / underlined).I used the
crosstermstyle system which I believe tui uses, so this should be compatible with the same terminals the current code is compatible with.The color style includes thresholds for certain values:
Here's an example of how the printer view looks:
