remove dcd_esp32sx which is replaced by dwc2 #3282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated ESP32-SX specific USB Device Controller (DCD) driver that has been replaced by the generic dwc2 driver. The change modernizes the ESP32 S2/S3 support by consolidating on a single, shared driver implementation.
Key changes:
- Removes the entire dcd_esp32sx.c driver file (889 lines)
- Updates IAR project generator to exclude the removed driver
- Simplifies audio device buffer configuration by removing ESP32SX-specific conditions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/portable/espressif/esp32sx/dcd_esp32sx.c | Complete removal of ESP32SX-specific USB device controller driver |
| tools/iar_gen.py | Removes dcd_esp32sx.c from blacklist, simplifying file filtering |
| src/class/audio/audio_device.c | Simplifies buffer type logic by removing ESP32SX exception |
| README.rst | Updates documentation to reflect ESP32 S2/S3 now only use dwc2 driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
A clear and concise description of what this PR solve.
Additional context
If applicable, add any other context about the PR and/or screenshots here.