Skip to content

Test Home Assistant's HTTP reverse proxy configuration on add-on startup#254

Merged
frenck merged 5 commits intohassio-addons:mainfrom
lmagyar:pr-test-proxy-connection
Oct 23, 2023
Merged

Test Home Assistant's HTTP reverse proxy configuration on add-on startup#254
frenck merged 5 commits intohassio-addons:mainfrom
lmagyar:pr-test-proxy-connection

Conversation

@lmagyar
Copy link
Copy Markdown
Collaborator

@lmagyar lmagyar commented Sep 8, 2023 •
edited
Loading

Proposed Changes

This will prevent "400: Bad Request" errors and redirects users to the Documentation.

Related Issues

@lmagyar lmagyar force-pushed the pr-test-proxy-connection branch from 9e25104 to 56b21ab Compare September 8, 2023 16:59
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 9, 2023
@lmagyar
Copy link
Copy Markdown
Collaborator Author

lmagyar commented Oct 10, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 11, 2023
@frenck frenck force-pushed the pr-test-proxy-connection branch from 56b21ab to dae9546 Compare October 15, 2023 16:21
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Oct 15, 2023
frenck
frenck requested changes Oct 15, 2023
View reviewed changes
frenck
frenck reviewed Oct 15, 2023
View reviewed changes
@frenck frenck marked this pull request as draft October 15, 2023 17:06
@lmagyar lmagyar force-pushed the pr-test-proxy-connection branch from e191099 to 8bc7a87 Compare October 20, 2023 15:45
@lmagyar
Copy link
Copy Markdown
Collaborator Author

lmagyar commented Oct 20, 2023

Rebased, to prevent merge conflicts (proxy service code will change a lot).

@frenck frenck mentioned this pull request Oct 22, 2023
Merged
@frenck frenck force-pushed the pr-test-proxy-connection branch from 8bc7a87 to 97a4b93 Compare October 22, 2023 15:25
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 22, 2023

Note: the unrelated changes are already in PR #277, this PR needs to be rebased after that is merged.

Please don't stack your PRs on top of each other. Make them clean and standalone. Can you rebase this one and pick only the related commits? Thanks 👍

../Frenck

@lmagyar lmagyar force-pushed the pr-test-proxy-connection branch from 97a4b93 to 8ebe468 Compare October 22, 2023 17:49
@lmagyar
Copy link
Copy Markdown
Collaborator Author

lmagyar commented Oct 22, 2023

And rebased also.

@lmagyar lmagyar marked this pull request as ready for review October 23, 2023 09:16
frenck
frenck approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like reasonable way to handle this 👍

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 7382fe4 into hassio-addons:main Oct 23, 2023
@lmagyar lmagyar deleted the pr-test-proxy-connection branch October 23, 2023 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmagyar @frenck