Drop support for armhf, armv7, and i386 systems#353
Conversation
WalkthroughThe pull request removes support for three CPU architectures (armhf, armv7, i386) across the project. Support is narrowed to aarch64 and amd64 only. This change is reflected in configuration files, Docker build logic, and documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
base/Dockerfile (1)
51-52: Consider defensive handling for unexpected BUILD_ARCH values.Currently, if an unexpected
BUILD_ARCHvalue is passed (e.g., due to misconfiguration or typo),S6_ARCHwill use the unrecognized value as-is, potentially causing a failed download. A defensive fallback or explicit validation could improve robustness.If you'd like to add explicit error handling, you could update the logic to:
&& S6_ARCH="${BUILD_ARCH}" \ - && if [ "${BUILD_ARCH}" = "amd64" ]; then S6_ARCH="x86_64"; fi \ + && if [ "${BUILD_ARCH}" = "amd64" ]; then S6_ARCH="x86_64"; elif [ "${BUILD_ARCH}" = "aarch64" ]; then S6_ARCH="aarch64"; else echo "Unsupported BUILD_ARCH: ${BUILD_ARCH}" >&2 && exit 1; fi \This ensures only supported architectures proceed and provides clear error messaging during build failures.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/renovate.json(1 hunks)README.md(0 hunks)base/Dockerfile(1 hunks)base/build.yaml(0 hunks)base/config.yaml(0 hunks)
💤 Files with no reviewable changes (3)
- base/config.yaml
- base/build.yaml
- README.md
🔇 Additional comments (2)
.github/renovate.json (1)
16-16: Architecture support correctly narrowed in Renovate configuration.The regex pattern is correctly scoped to only monitor
aarch64andamd64builds, eliminating dependency update noise for the dropped architectures. This aligns with concurrent removal ofarmhf,armv7, andi386from the build configuration.base/Dockerfile (1)
51-52: S6 overlay architecture mapping correctly simplified and verified.The conditional now only remaps
amd64tox86_64(as required by s6-overlay release artifacts), whileaarch64uses the native BUILD_ARCH value. Verification confirms that s6-overlay v3.2.1.0 provides release artifacts for bothx86_64andaarch64, confirming the change is sound.
Proposed Changes
The Home Assistant project has deprecated support for the armv7, armhf and i386 architectures. Support wil be fully dropped in the upcoming Home Assistant 2025.12 release.
This PR drop support for it from our base images.
../Frenck
Blogging my personal ramblings at frenck.dev
Summary by CodeRabbit