Resolve #136: Accept "element-6066-11e4-a52e-4f735466cecf" as well as "ELEMENT" #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ced0642 to
fc1d3fe
Compare
Member
|
Awesome! Great change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #136
Nice to meet you!
This PR modifies
instance FromJSON Elementso that it accepts"element-6066-11e4-a52e-4f735466cecf"as well as"ELEMENT".This is a quick-fix which doesn't really try to adhere to the W3C protocol, unlike #144. That said, this fix improves the situation with Firefox from "not working at all" to "somehow working". Also, it's what the official Python remote webdriver appears to be doing: remote/webdriver.py
If interested, here is the script I used.
This PR includes a couple of other fixes which address the compiler warnings.