Conversation
Kleidukos
left a comment
There was a problem hiding this comment.
Hi, and thank you for this contribution!
2 things:
-
It seems that your editor has taken upon itself to reformat the codebase. We abide by the CI and Fourmolu to do that. Especially, the
ImportQualifiedPostextension is not supported by some of the versions of GHC tested in CI. -
Yes I'd very much prefer that you include it in the changelog :)
|
I formatted it according to the |
|
Ah I know why that happened; I have a big fourmolu command I run over all my files and that has -XImpirtQualifiedPost; however, the formatting seems not to be up to date on main, anyhow. |
6039de1 to
44eb33e
Compare
|
sorry for the fuzz. |
|
@MangoIV could you please rebase your PR on |
44eb33e to
2f735a1
Compare
2f735a1 to
2b71b32
Compare
|
done 👍 |
Kleidukos
left a comment
There was a problem hiding this comment.
Fantastic! Thank you very much for this addition :)
Submitter checklist
I have updated the instances to also contain an instance for
Void, I have not included a note in theCHANGELOG.mdbecause I think that it's much more a fix of a missing instance than a feature addition. If you like me to also add it to theCHANGELOG, just tell me.