Media types for GitHub API previews #367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't feel I'd like to keep that preview list explicitly in the library. |
Contributor
Author
|
I had a go first at refactoring things to allow the media types externally, but it started to get seriously messy. I was hoping you might accept having the list of media types in this library because those strings should at least be stable, but maybe I'll have to give the refactoring another shot instead. |
Contributor
|
I think we can change I'll see what I can do, Draft Pull Requests seems to be something which is easy to test with. |
Contributor
|
Superseded by #370 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the media types used by API previews. This will allow users of this library to use the existing
GenRequesttype and its constructors when writing functions that use endpoints from API previews.