Skip to content

Consistently rename ciphertext-related types and functions in sel#182

Merged
Kleidukos merged 5 commits intohaskell-cryptography:mainfrom
intricate:rename-sel-secretkey-cipher-hash
Mar 21, 2025
Merged

Consistently rename ciphertext-related types and functions in sel#182
Kleidukos merged 5 commits intohaskell-cryptography:mainfrom
intricate:rename-sel-secretkey-cipher-hash

Conversation

@intricate
Copy link
Copy Markdown
Contributor

@intricate intricate commented Feb 17, 2025

Resolves #181

In sel, why do we refer to the ciphertext + authentication tag secretbox output as a "hash"? At a glance, this seems like it could be misleading.

intricate
intricate commented Feb 17, 2025
View reviewed changes
intricate
intricate commented Feb 17, 2025
View reviewed changes
@Kleidukos
Copy link
Copy Markdown
Member

Kleidukos commented Feb 25, 2025 •
edited
Loading

Since this a breaking change of the API, could you introduce a changelog entry (https://github.com/haskell-cryptography/libsodium-bindings/blob/main/sel/CHANGELOG.md) for v0.1.0.0 ? And bump the version in sel.cabal as well?

@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from 669f2d6 to a9159e8 Compare February 25, 2025 22:34
@intricate intricate requested a review from Kleidukos February 25, 2025 22:34
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from a9159e8 to 2b97374 Compare February 26, 2025 12:58
@Kleidukos Kleidukos requested review from a-02 and kozross February 26, 2025 15:03
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch from 2b97374 to 2b7b18d Compare February 27, 2025 03:26
@intricate intricate changed the title Rename Sel.SecretKey.Cipher.Hash to Ciphertext Consistently rename ciphertext-related types and functions in sel Feb 27, 2025
@intricate intricate force-pushed the rename-sel-secretkey-cipher-hash branch 3 times, most recently from 0153e72 to b09a7ff Compare February 27, 2025 03:49
@intricate
Copy link
Copy Markdown
Contributor Author

intricate commented Mar 19, 2025

hi all, not to be a bother, but I just wanted to check in on this 😁

@Kleidukos
Copy link
Copy Markdown
Member

Kleidukos commented Mar 19, 2025

@intricate thanks, I'm on it. :)

@Kleidukos Kleidukos self-assigned this Mar 21, 2025
@Kleidukos
Copy link
Copy Markdown
Member

Kleidukos commented Mar 21, 2025

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 21, 2025

rebase

✅ Branch has been successfully rebased

@Kleidukos Kleidukos force-pushed the rename-sel-secretkey-cipher-hash branch from b09a7ff to 7c1f238 Compare March 21, 2025 09:00
Kleidukos
Kleidukos approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intricate Thank you for your patience! This is excellent work and I'm really honoured you felt that this project was worth contributing to. 🙇

@Kleidukos Kleidukos merged commit af56037 into haskell-cryptography:main Mar 21, 2025
15 checks passed
@intricate intricate deleted the rename-sel-secretkey-cipher-hash branch March 21, 2025 14:21
@intricate
Copy link
Copy Markdown
Contributor Author

intricate commented Mar 21, 2025

@Kleidukos: No problem at all. Happy to help out and continue contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kleidukos Kleidukos Kleidukos approved these changes

@kozross kozross Awaiting requested review from kozross

@a-02 a-02 Awaiting requested review from a-02

Assignees

@Kleidukos Kleidukos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Naming of Sel.SecretKey.Cipher.Hash

2 participants

@intricate @Kleidukos