Skip to content

feat: add constant time hex encoding#176

Merged
Kleidukos merged 1 commit intohaskell-cryptography:mainfrom
jhenahan:feat/constant-time-hex-encoding
Jan 21, 2025
Merged

feat: add constant time hex encoding#176
Kleidukos merged 1 commit intohaskell-cryptography:mainfrom
jhenahan:feat/constant-time-hex-encoding

Conversation

@jhenahan
Copy link
Copy Markdown
Contributor

@jhenahan jhenahan commented Jan 8, 2025

Pretty much what it says on the tin. Adds a higher-level wrapper around the sodium_bin2hex() binding, and uses the wrapper to implement all functions meant to produce a hexadecimal-encoded bytestring.

@jhenahan jhenahan requested a review from Kleidukos January 8, 2025 04:34
Copy link
Copy Markdown
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the PR and add a changelog entry. :p

@jhenahan jhenahan force-pushed the feat/constant-time-hex-encoding branch from e73dd70 to b539bca Compare January 20, 2025 16:13
@jhenahan jhenahan requested a review from Kleidukos January 20, 2025 16:16
@jhenahan jhenahan force-pushed the feat/constant-time-hex-encoding branch from 81c492a to cda13d6 Compare January 21, 2025 02:31
Copy link
Copy Markdown
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kleidukos Kleidukos merged commit 4fb4324 into haskell-cryptography:main Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants