Treeowl map maybe m #333
Merged
Treeowl map maybe m #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ```haskell mapMaybeM :: Monad m => (a -> m (Maybe b)) -> Vector a -> m (Vector b) imapMaybeM :: Monad m => (Int -> a -> m (Maybe b)) -> Vector a -> m (Vector b) ``` `mapMaybeM` is similar to `wither`, but the stream fusion framework seems to require that we use a `Monad` constraint rather than an `Applicative` one to get good performance. `imapMaybeM` is the indexed variant. Resolves #183
lehins
reviewed
Oct 10, 2020
lehins
reviewed
Oct 10, 2020
lehins
approved these changes
Oct 10, 2020
Contributor
lehins
left a comment
There was a problem hiding this comment.
Couple of minor comments, but otherwise looks great.
Co-authored-by: Alexey Kuleshevich <alexey@kuleshevi.ch>
f984f62 to
4dffcd1
Compare
Bodigrim
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #226 rebased on top of master and with haddocks. Only think holding #226 is lack of documentation so I think now it's ready to merge.
Fixes #183