Implement unfoldrExactN & unfoldrExactNM #295
Conversation
lehins
left a comment
There was a problem hiding this comment.
Implementation looks good, but haddock needs fixing, it still describes the behavior of unfoldrN functions
Data/Vector.hs
Outdated
|
|
||
| -- | /O(n)/ Construct a vector with at most @n@ elements by repeatedly applying | ||
| -- the generator function to a seed. The generator function yields 'Just' the | ||
| -- next element and the new seed or 'Nothing' if there are no more elements. |
There was a problem hiding this comment.
Here and other places the doc was copy pasted and needs fixing.
Data/Vector/Fusion/Stream/Monadic.hs
Outdated
| {-# INLINE_FUSED unfoldrExactN #-} | ||
| unfoldrExactN n f = unfoldrExactNM n (return . f) | ||
|
|
||
| -- | Unfold at most @n@ elements with a monadic functions |
There was a problem hiding this comment.
Should say Unfold exactly @n@ elements ...
There was a problem hiding this comment.
And I thought I fixed haddock... Thanks! I guess I mixed up copy-paste somewhere
There was a problem hiding this comment.
The doc is still not right :)
Should say: Unfold exactly @n@ elements with a monadic function
(note function is not plural)
457009d to
021f57b
Compare
|
I think I fixed haddocks |
Data/Vector/Fusion/Bundle.hs
Outdated
| {-# INLINE unfoldrN #-} | ||
| unfoldrN = M.unfoldrN | ||
|
|
||
| -- | Unfold at most @n@ elements |
There was a problem hiding this comment.
Same here:
Unfold exactly @n@ elements
021f57b to
1052844
Compare
1052844 to
8cf8345
Compare
|
I made a minor adjustment to this PR: lehins@ccc6e50 Once the CI passes it will be good to merge |
Fixes #140