Add ghc-lib flag to force use ghc-lib-parser even if ghc is supported#402
Merged
jaspervdj merged 3 commits intohaskell:mainfrom Apr 27, 2022
Merged
Add ghc-lib flag to force use ghc-lib-parser even if ghc is supported#402jaspervdj merged 3 commits intohaskell:mainfrom
jaspervdj merged 3 commits intohaskell:mainfrom
Conversation
jaspervdj
approved these changes
Apr 27, 2022
Member
jaspervdj
left a comment
There was a problem hiding this comment.
This is excellent, I was looking into supporting both ghc9 and ghc9.2 but the API differences turned out to be more than I expected. Thanks a lot! I'm happy to release this today.
Just one minor nitpick: can we remove the version bump? I prefer to do this in a separate commit since I have a bunch of scripts for this.
Co-authored-by: Jasper Van der Jeugt <jaspervdj@gmail.com>
Contributor
Author
|
FYI, I have a branch on ghc9.0 https://github.com/July541/stylish-haskell/tree/ghc-9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this pr adds a ghc-lib flag to force use ghc-lib-parser even if ghc is supported. HLS will benefit a lot since we can support hls-stylish-haskell-plugin and hls-hlint-plugin on ghc9.2 simultaneously. I would appreciate it if this pr is accepted with a new release. Thanks in advance.
The necessity is here haskell/haskell-language-server#2854 (comment)