As suggested by @pepeiborra, we have a better alternative to FilePath now. See: https://hasufell.github.io/posts/2022-06-29-fixing-haskell-filepaths.html
And changing the implementation of NormalizedFilePath might greatly impact HLS performance, according to the existing comment.
|
-- This is one of the most performance critical parts of ghcide, do not |
|
-- modify it without profiling. |
|
data NormalizedFilePath = NormalizedFilePath NormalizedUri !FilePath |
I'm planning to:
- Modify lsp-types to use
OsPath in a fork
- Create a hls branch using that fork
- Profiling, to verify the performance (especially memory) impact
As suggested by @pepeiborra, we have a better alternative to
FilePathnow. See: https://hasufell.github.io/posts/2022-06-29-fixing-haskell-filepaths.htmlAnd changing the implementation of
NormalizedFilePathmight greatly impact HLS performance, according to the existing comment.lsp/lsp-types/src/Language/LSP/Types/Uri.hs
Lines 158 to 160 in a41954e
I'm planning to:
OsPathin a fork