Closed
Conversation
Contributor
Author
|
Fixed hardcoded package name and adaded ifdefs guarding differences between 9.2 and 9.4. |
Collaborator
We just dropped support for 8.6 and 8.8 is going to be dropped soon, so don't bother. Does 8.10 work? |
Collaborator
|
Don't forget enabling the testsuite in the |
This is work in progress, it will likely not compile for older ghc version, and so far it doesn't handle unit ids at all. It is hardcoded for package "blah" version 0.1.0.0 now. Proper solutions for those issues will show up in separate commits
Also makes code compile (and still work) on ghc 9.2.
Contributor
Author
|
Ghc 8.10.7 seems to still work fine. Rebased on top of main commit, and enabled tests. I updated some tests for ghc94, but I have 6 left failing due to a difference in error format. I will try to figure that out over the weekend and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work in progress, but it works(given issues below) :)
It will not compile for older ghc version, and so far it doesn't handle unit ids at all.
It is hardcoded for package "blah" version 0.1.0.0 now. Proper solutions for those issues will show up in separate commits
It will need rebase when #3249 lands.
Leaving it as draft until I get it to a better state