Skip to content

Make work stack-9.2.1.yaml and enable pedantic (-WError) for cabal #2606

Merged
mergify[bot] merged 54 commits intohaskell:masterfrom
jneira:stack-ghc-9.2.1
Jan 20, 2022
Merged

Make work stack-9.2.1.yaml and enable pedantic (-WError) for cabal #2606
mergify[bot] merged 54 commits intohaskell:masterfrom
jneira:stack-ghc-9.2.1

Conversation

@jneira
Copy link
Copy Markdown
Member

@jneira jneira commented Jan 19, 2022 •
edited
Loading

  • Going deeper underground:
  1. Make stack build work for ghc-9.2.1
  2. It turns out that it has enable pedantic for the hls packahe so i had to fix somewarnins in func-test
  3. I remembered @michaelpj and me talked about make consistent the use of the flag
  4. Enable the flag for the default cabal build
  5. Fix a good bunch of warning everywhere 😆 , several of them in tactics

jneira added 30 commits January 19, 2022 19:15
@jneira
Enable brittany for ghc-9.0.2
30994b8
@jneira
Make works using cabal freeze
442446d
@jneira
Add stack 9.2.1 to ci
87dd04d
@jneira
Use new *molu versions
0aafc17
@jneira
Enable rename for stack 9.2.1
5585cae
@jneira
Use last ghc-lib
54329f8
@jneira
Use correct boot pkgs
9294146
@jneira
Use last ghc-exactprint
7899e43
@jneira
Reorganize and use lens-5.1
eb52367
@jneira
update retrie
49ce94a
@jneira
Comment class plugin package
c116360
@jneira
Handle Nothing case
7b7f9fc
@jneira
Restore ghc-typelits deps
caa33d0
@jneira
More non-exhaustive patterns
9af8ae8
@jneira
More non-exhaustive patterns
0ceaf64
@jneira
Set pedantic (-WError) true for cabal
d96e514
@jneira
Remove pedantic as we set it out in cabal.project
7b43c62
@jneira
Not set pedantic for ghc-9.2.1
0b4c99c
@jneira
Set pedantic in cabal.project's
e873ba4
@jneira
More non-exhaustive patterns
d38892c
@jneira
Not set pedantic for ghc-9.0.1
fa72a58
@jneira
More incomplete patterns
a52b550
@jneira
Fix WErrors
7e9c938
@jneira
Dodgy import
02c09bb
@jneira
Correct CPP conditions
2668760
@jneira
Not MonadFail in Prelude
0eaf0d4
@jneira
Fix more warnings
f5c5acd
@jneira
Restore missing fun
a75dae7
@jneira
unused imports
6061889
@jneira
Enable refine imports
67ef152
@jneira
Copy link
Copy Markdown
Member Author

jneira commented Jan 19, 2022

stack build does not work anymore, since https://app.circleci.com/pipelines/github/jneira/haskell-language-server/1506/workflows/bf168e6e-0c8e-4784-95a1-c98d555c5358/jobs/12418 😢

@jneira jneira force-pushed the stack-ghc-9.2.1 branch 4 times, most recently from 6960a88 to 673c032 Compare January 20, 2022 07:56
@jneira
Copy link
Copy Markdown
Member Author

jneira commented Jan 20, 2022

I am trying to fix the build release workflow here and i am afraid we have a new dependency which needs integer-gmp. As we are building the binaries for linux with alpine where some ghcs are using integer-simple, the build fails:

Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: ghcide-1.5.0.1 (user goal)
[__1] trying: lsp-types-1.4.0.0 (dependency of ghcide)
[__2] trying: mod-0.1.2.2 (dependency of lsp-types)
[__3] next goal: integer-gmp (dependency of mod)
[__3] rejecting: integer-gmp-1.0.3.0, integer-gmp-1.0.2.0,
integer-gmp-1.0.1.0, integer-gmp-1.0.0.1, integer-gmp-1.0.0.0,
integer-gmp-0.5.1.0 (only already installed instances can be used)
[__3] fail (backjumping, conflict set: integer-gmp, mod)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, ghcide, integer-gmp, lsp-types,
mod

afaics mod has no flag to switch to integer-simple like we are doing for blaze-textual

//cc @michaelpj @Bodigrim

@michaelpj
Copy link
Copy Markdown
Collaborator

michaelpj commented Jan 20, 2022

I suggest we leave the integer-simple issue for another PR since this is getting big.

michaelpj
michaelpj reviewed Jan 20, 2022
View reviewed changes
.github/workflows/flags.yml
# we have to clean up warnings for 9.0 and 9.2 before enable -WAll
- if: matrix.ghc != '9.0.2' && matrix.ghc != '9.2.1'
name: Build with pedantic (-WError)
run: cabal v2-build --flags="pedantic"
Copy link
Copy Markdown
Collaborator

@michaelpj michaelpj Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will rebuild everything, I think? do we want that? seems like it'll make the workflow slow. Maybe it's okay.

Copy link
Copy Markdown
Member Author

@jneira jneira Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only local packages (as --flags only affect them), even the ones without the flag as we have one package in the root of the local dependency tree with the flag available

@jneira
Copy link
Copy Markdown
Member Author

jneira commented Jan 20, 2022

I suggest we leave the integer-simple issue for another PR since this is getting big.

yeah i've already accumulated too many things here

@jneira
Copy link
Copy Markdown
Member Author

jneira commented Jan 20, 2022

@michaelpj it is the pr ok to merge (ignoring fo now the release build failure)?

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 20, 2022
@mergify mergify bot merged commit 2558035 into haskell:master Jan 20, 2022
This was referenced Jan 20, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isovector isovector isovector approved these changes

@michaelpj michaelpj michaelpj approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jneira @michaelpj @isovector