Backport 1.9.x: Add PKCE to OIDC Auth (#188)#191
Merged
fairclothjm merged 1 commit intorelease/vault-1.9.xfrom Dec 8, 2021
Merged
Backport 1.9.x: Add PKCE to OIDC Auth (#188)#191fairclothjm merged 1 commit intorelease/vault-1.9.xfrom
fairclothjm merged 1 commit intorelease/vault-1.9.xfrom
Conversation
* Add PKCE to OIDC authorization code logins * Add tests * fix comment typos * check for code response type Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
austingebauer
approved these changes
Dec 7, 2021
calvn
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #188
The following steps were taken:
git checkout release/vault-1.9.xgit checkout -b backport-pr-188-1.9.xgit cherry-pick 7010da264993747d78ec4fab83505abab0b97c25