fix: remove case transformation in normalizeOutputKey#537
Closed
martinsolberg wants to merge 1 commit intohashicorp:mainfrom
Closed
fix: remove case transformation in normalizeOutputKey#537martinsolberg wants to merge 1 commit intohashicorp:mainfrom
martinsolberg wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
|
Collaborator
|
@martinsolberg Hi, I am sorry you are having trouble here. I think this use case makes sense. However, I think this may be a breaking change. (I haven't tested it or run the acceptance tests yet). How will this change affect the existing behavior of normalizing the selector key: https://github.com/hashicorp/vault-action?tab=readme-ov-file#simple-key? |
Author
|
@fairclothjm That may very well be the case, I do not have sufficient insight to make a judgement on that. If this change introduces some unfortunate consequences, someone else will have to have a go at it. |
Elias-Chairi
approved these changes
Mar 20, 2024
1 task
Author
|
Use #545 to resolve this issue instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes case transformation in normalizeOutputKey. Will allow keys to be exported as environment variables with case intact when using wildcard lookup.
Closes #536
Checklist
Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request