revert fix secrets stored in JSON format (#473)#478
Merged
fairclothjm merged 1 commit intomainfrom Jul 13, 2023
Merged
Conversation
7e655cd to
77a7336
Compare
vinay-gopalan
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will revert to the behavior vault-action has exhibited since v2.1.2. This ensure that all JSON is valid when set as an environment variable and that step output will be a JSON object.
I can't find the source code of github actions to actually verify this, but it seems to me that when the step output is passed to another action using the
withkeyword, the github action framework actuallyJSON.stringify's the data. This means that anything that accepts a Vault secret as input will have a valid JSON string that can then beJSON.parse'd. For example, this allows the following to work: