Skip to content

fix(secrets): allow dynamic secrets to be read#398

Closed
ibacalu wants to merge 1 commit intohashicorp:mainfrom
ibacalu:main
Closed

fix(secrets): allow dynamic secrets to be read#398
ibacalu wants to merge 1 commit intohashicorp:mainfrom
ibacalu:main

Conversation

@ibacalu
Copy link
Copy Markdown

@ibacalu ibacalu commented Nov 10, 2022

This would allow reading of data.* thus accessing all dynamic secret properties.
Resolves #396

This would allow reading of `data.*` thus accessing all dynamic secret properties
Resolves hashicorp#396
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@bimtauer
Copy link
Copy Markdown

bimtauer commented Mar 16, 2023

Gentle bump, could you please review this? 🙏🏼

@maxcoulombe
Copy link
Copy Markdown
Contributor

Hi, would you say this review accomplishes the same objective of allowing users to read all properties of a secret at once?

If yes, I think it'd be preferable to focus on #238 as I find the added functionality of being able to optionally add a prefix useful to avoid collisions and group related secret properties.

@ibacalu
Copy link
Copy Markdown
Author

ibacalu commented May 9, 2023

@maxcoulombe I haven't tested out #238. It could work as well although the actual use case might be different.
This PR would allow us to get dynamic secrets from Vault.
This would be an example:

secrets: |
          postgres/creds/dbname * | DB_CRED;

The trick with dynamic secrets is that you can only make 1 request. Every additional request is going to generate different values.
If #238 can do the same with 1 request only, and stores the keys with a prefix, then yes, let's go for that.
Anything that would unblock this thing.

@fairclothjm
Copy link
Copy Markdown
Collaborator

Closing as this should be fixed by #488.

Please feel free to reopen if you feel this was a mistake, or if there is additional information to add. Thanks!

@fairclothjm fairclothjm closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Support reading temporary database credentials

5 participants