Update plugin proto to send tls.ConnectionState (Op.2)#12581
Merged
ncabatoff merged 4 commits intohashicorp:mainfrom Oct 7, 2021
tep:tls-state-plugins
Merged
Update plugin proto to send tls.ConnectionState (Op.2)#12581ncabatoff merged 4 commits intohashicorp:mainfrom tep:tls-state-plugins
ncabatoff merged 4 commits intohashicorp:mainfrom
tep:tls-state-plugins
Conversation
Contributor
|
Hi @tep! It looks like there's some merge conflicts. Can you resolve those? Then, the tests all look good and we can do a deeper dive on the review. |
Contributor
Author
|
@hsimon-hashicorp -- Conflicts resolved |
ncabatoff
approved these changes
Oct 7, 2021
Collaborator
|
Nice work, thanks @tep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #9240; it still fixes #9213
In order for external plugins to examine the client certificate(s)
presented during the original request into Vault, we need to marshal
that request's tls.ConnectionState across the gRPC boundary from the
Vault server to the external plugin process.
To that end, this change updates the protocol buffer (and associated
translation logic) used for communicating with external plugins to
include the logical.Connection's "ConnState" value -- thus making it
available to the logical.Request passed to callbacks defined by
external plugins.