Skip to content

Add missing word "database" in docs#12274

Closed
tvsaru wants to merge 5 commits intohashicorp:mainfrom
tvsaru:saru-minor-fixes-2021
Closed

Add missing word "database" in docs#12274
tvsaru wants to merge 5 commits intohashicorp:mainfrom
tvsaru:saru-minor-fixes-2021

Conversation

@tvsaru
Copy link
Copy Markdown
Contributor

@tvsaru tvsaru commented Aug 6, 2021

SQL is the language and based on second bullet point the author probably intended SQL "database".

tvsaru added 2 commits August 5, 2021 23:06
Add missing word database
Add missing "database" keyword.
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Aug 6, 2021

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • taoism4504
  • tvsaru

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – vault-storybook August 6, 2021 03:43 Inactive
@tvsaru tvsaru changed the title Saru minor fixes 2021 Add missing word "database" in docs Aug 6, 2021
@tvsaru
Copy link
Copy Markdown
Contributor Author

tvsaru commented Aug 6, 2021

Will check with employer on respective terms in the CLA.

@heatherezell
Copy link
Copy Markdown
Contributor

Hi @tvsaru - were you able to get clarity on whether you'll be able to sign the CLA? Please let me know how we can help. Thanks!

Copy link
Copy Markdown

@klaporte klaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should say "a SQL database" versus "an SQL database".

@tvsaru tvsaru requested a review from taoism4504 as a code owner October 13, 2021 13:53
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 13, 2021 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 13:53 Inactive
@tvsaru
Copy link
Copy Markdown
Contributor Author

tvsaru commented Oct 13, 2021

@klaporte, the debate about should SQL use "a" or "an" as the indefinite article seems to be confusing everyone. My confusion came from the fact that when I say SQL I say the letters separately, and end up using "an" for the same reason noted in https://oracle-base.com/blog/2015/01/02/a-sql-or-an-sql/.

In this context, at least when writing I am going to take your suggestion and use 'a'.

--
FYI hashicorp team, these are the other places I see discrepancies of "an" vs "a":

Comment thread website/content/docs/what-is-vault.mdx Outdated
Copy link
Copy Markdown
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvsaru
Copy link
Copy Markdown
Contributor Author

tvsaru commented Oct 21, 2021

Based on our company policies I need to push this change via Bloomberg fork, as we have a corporate level agreement for the CLA. Will do that next week. Thanks for your patience.

@pmmukh
Copy link
Copy Markdown
Contributor

pmmukh commented Dec 17, 2021

Hey @tvsaru ! Did you maybe end up creating a separate PR for this change ? Was wondering if this one should be closed out.

@tvsaru
Copy link
Copy Markdown
Contributor Author

tvsaru commented Jan 5, 2022

Issued PR #13571 via bloomberg org to leverage the company-level CLA agreement.

@tvsaru tvsaru closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants