all: Fix various bugs related to resource type names that match the provider type name (i.e. no resource type suffix)#421
Merged
austinvalle merged 7 commits intomainfrom Nov 26, 2024
Merged
Conversation
…e as the provider were flagged as invalid
…erwrites all other documentation files
1 task
SBGoods
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #419
This PR fixes three bugs, two of which were related to resource type names that have no type name and are equal to the provider name itself, which is valid. (Example:
httpdata source from theterraform-provider-httpprovider)validatecommand, resource types that had no type name would return a validation error for file mismatchinggeneratecommand, resource types that had no type name would take priority over other files present, introduced in Allowing single word resources to use templates #147. I believe this was likely caused because we didn't have any providers that had multiple resources alongside a resource with a type name the same as the provider 🙃The third bug was just related to static file copying from templates:
generatecommand, static files which we wish to not overwrite in the destination should not cause the docs generator to throw an error.Notes
.vscodefolder at the root of this project, since we don't typically include IDE files in repositories