Refactor mdplain package to use yuin/goldmark library for markdown processing#332
Merged
Refactor mdplain package to use yuin/goldmark library for markdown processing#332
mdplain package to use yuin/goldmark library for markdown processing#332Conversation
bflad
approved these changes
Jan 26, 2024
Contributor
bflad
left a comment
There was a problem hiding this comment.
Looks good to me 🚀 (I'm assuming there are no differences with the unit test between the prior implementation and this new one without explicitly verifying.)
Contributor
There was a problem hiding this comment.
I love using this to verify the functionality ❤️
This was referenced Apr 16, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #321
This PR adds a golden file test for the
PlainMarkdown()function and refactors themdplainpackage to useyuin/goldmarklibrary instead ofrussross/blackfridayfor markdown processing.