Correctly handle *ast.AutoLink nodes in the plainmarkdown function#361
Merged
Correctly handle *ast.AutoLink nodes in the plainmarkdown function#361
*ast.AutoLink nodes in the plainmarkdown function#361Conversation
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #360
Fixes a bug where plain URLs (ie
https://github.com/) were missing from theplainmarkdownfunction output. Thegoldmarklibrary treats links (ie[link](http://github.com/)) as a different node type from plain URLs. The previous code for handling the*ast.AutoLinknode type for plain URLs would output theText()method for the node instead of theURL()method. This PR calls the correct method and adds a corresponding unit test case.