Skip to content

Backport of backend/s3: Adds parameter skip_s3_checksum to skip checksum on upload into v1.6#34130

Merged
gdavison merged 4 commits intov1.6from
backport/s3/b-s3-checksum/apparently-suited-macaque
Oct 24, 2023
Merged

Backport of backend/s3: Adds parameter skip_s3_checksum to skip checksum on upload into v1.6#34130
gdavison merged 4 commits intov1.6from
backport/s3/b-s3-checksum/apparently-suited-macaque

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 24, 2023

Backport

This PR is auto-generated from #34127 to be assessed for backporting due to the inclusion of the label 1.6-backport.

The below text is copied from the body of the original PR.


Some "S3-compatible" APIs do not support the header x-amz-sdk-checksum-algorithm. In the S3 API, a checksum is recommended and is required when Object Lock is enabled.

Allow users to disable the header.

Fixes #34099
Fixes #34086
Relates #34053 (comment)

Target Release

1.6.3

Draft CHANGELOG entry

ENHANCEMENTS

  • backend/s3: Allows users to disable checksum on S3 uploads for compatibility with "S3-compatible" APIs

Overview of commits

@ghost ghost self-requested a review as a code owner October 24, 2023 18:33
@ghost ghost force-pushed the backport/s3/b-s3-checksum/apparently-suited-macaque branch from bf558c3 to 0887abb Compare October 24, 2023 18:33
@ghost ghost assigned gdavison Oct 24, 2023
@ghost ghost force-pushed the backport/s3/b-s3-checksum/apparently-suited-macaque branch from 98421ee to b026bc6 Compare October 24, 2023 18:33
@ghost ghost requested a review from gdavison October 24, 2023 18:33
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@gdavison gdavison force-pushed the backport/s3/b-s3-checksum/apparently-suited-macaque branch from b026bc6 to 287a758 Compare October 24, 2023 18:42
@gdavison gdavison merged commit 158fd5a into v1.6 Oct 24, 2023
@gdavison gdavison deleted the backport/s3/b-s3-checksum/apparently-suited-macaque branch October 24, 2023 19:44
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@12345ieee
Copy link
Copy Markdown

Looking forward to testing this as soon as 1.6.3 lands.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants