wrapper: Write stdout/stderr data to stream when received#410
Merged
austinvalle merged 6 commits intomainfrom May 7, 2024
Merged
wrapper: Write stdout/stderr data to stream when received#410austinvalle merged 6 commits intomainfrom
austinvalle merged 6 commits intomainfrom
Conversation
austinvalle
commented
Apr 25, 2024
bflad
approved these changes
May 6, 2024
Contributor
bflad
left a comment
There was a problem hiding this comment.
Looks good to me (with my limited understanding of this part of NodeJS) 🚀
ansgarm
approved these changes
May 7, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
Closes #405
This PR restores the equivalent of the wrapper's original behavior to immediately output to STDOUT and STDERR when data is received. I've attached a demo video of the new delayed test.
Context
Prior to #367, we relied on the
@actions/execpackage to immediately write to STDOUT and STDERR (which is the default behavior ofsilent: false), see the relevant underlying code.Since we can't utilize the
@actions/execpackage's default behavior, due to the debug/command output being passed to the wrapper (actions/toolkit#649), we can just update our original listener to just write the data as it's being buffered. Shout out to @dannystaple for the original thought!Demo
streaming-output.mov