Upgrade Nodejs runtime from 12 to 16#170
Upgrade Nodejs runtime from 12 to 16#170jpogran merged 5 commits intohashicorp:mainfrom chenrui333:update-runtime-to-nodejs@16
Conversation
|
It is also desired to make a new release after this PR update. |
|
Thanks for working on this! It was on my list of thing to do, but hadn't gotten to it yet. I admit I'm a bit nervous with the jump from 12 to 16, so we'll have to test this a bunch before we increment the v1 tag. |
I have to say, there is not much surprise that I have seen so far (ultimately it is just action runner update). :) |
|
Also, it should be a major upgrade. With the runtime pointing to node16, it would only work Actions Runners v2.285.0 or later. |
|
Good point. I'll create separate milestones. I think the changes so far since last release are fine for 1.4, but a 2.0 for a major runner bump is warranted. |
|
Sounds good, we can do two releases separately. 👍 😄 |
|
Hey @chenrui333 - this looks great (and tests well!) @jpogran just released |
|
totally, let me refresh my PR. |
|
Any timeline to merge this PR? |
|
@chenrui333 I'll be reviewing the open PRs this week and determining which land in 2.0. Look towards that milestone for a delivery date this week |
100% this - follows the same pattern as the |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
Updating this in preparation for merge |
|
Thanks for the help @chenrui333 , this will go out in the 2.0 release, currently slated for 2022/04/15 |
|
Sounds good, thanks @jpogran! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is consistent with all the recent github action updates. (mostly in
actionsrepos, likeactions/checkout,actions/setup-node, etc.)cc @jpogran