Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

Set consent manager cookie expiry to 6 months#407

Merged
zchsh merged 2 commits intomainfrom
mw.adjust-consent-manager-cookie-expiry
Oct 21, 2021
Merged

Set consent manager cookie expiry to 6 months#407
zchsh merged 2 commits intomainfrom
mw.adjust-consent-manager-cookie-expiry

Conversation

@mwickett
Copy link
Copy Markdown
Contributor

@mwickett mwickett commented Oct 19, 2021

🎟️ Asana Task
🔍 Preview Link

Via Legal and Security, this sets our Consent Manager cookie expiry to 6 months.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 19, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: aad0803

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-consent-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/react-components/DADY6nMxhj43jGEvf9dNSHuHHDN6
✅ Preview: https://react-components-git-mwadjust-consent-manager-615d06-hashicorp.vercel.app

@mwickett
Copy link
Copy Markdown
Contributor Author

mwickett commented Oct 19, 2021

@zchsh I have this PR for consent-manager as well, so we could bundle this into the version bump rollout for your #406

brkalow
brkalow approved these changes Oct 19, 2021
View reviewed changes
Comment thread packages/consent-manager/partials/cookies.js
import assign from 'object-assign'
export const COOKIE_KEY = 'hashi-consent-preferences'
export const COOKIE_EXPIRES = 365
export const COOKIE_EXPIRES = 183
Copy link
Copy Markdown
Contributor

@brkalow brkalow Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rounding up, I see 😉

Copy link
Copy Markdown
Contributor Author

@mwickett mwickett Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤫

@mwickett
Copy link
Copy Markdown
Contributor Author

mwickett commented Oct 19, 2021

@brkalow I just added a changeset...which I think I need? Very cool process for sure.

@brkalow
Copy link
Copy Markdown
Contributor

brkalow commented Oct 19, 2021

@mwickett Yep, here's some docs on the process: https://github.com/hashicorp/react-components#publishing

@zchsh zchsh merged commit 7674ae9 into main Oct 21, 2021
@zchsh zchsh deleted the mw.adjust-consent-manager-cookie-expiry branch October 21, 2021 17:02
@github-actions github-actions bot mentioned this pull request Oct 21, 2021
Merged
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost ghost mentioned this pull request Dec 3, 2021
Merged
This was referenced Dec 7, 2021
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brkalow brkalow brkalow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mwickett @brkalow @zchsh