feat: add support for UDR in packer-sdc binary#312
Merged
anurag5sh merged 4 commits intohashicorp:mainfrom Jan 14, 2026
Merged
Conversation
anurag5sh
reviewed
Jan 12, 2026
anurag5sh
previously approved these changes
Jan 13, 2026
Contributor
anurag5sh
left a comment
There was a problem hiding this comment.
Rest all looks good to me. LGTM!
anurag5sh
reviewed
Jan 13, 2026
cmd/packer-sdc/packer-sdc
Outdated
Contributor
There was a problem hiding this comment.
Do we need this binary to be part of the repo?
Contributor
Author
There was a problem hiding this comment.
Good catch, I removed that in the latest commit
Contributor
Author
|
I don't think I have access to push this PR to main after it is approved so please feel free to merge it when it is approved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the struct_markdown file to support the correct file locations in the UDR repo. This is necessary so the generate command in the makefile in UDR works correctly to update the mdx partials in that directory.
FYI: This is my first time contributing to this repo and using go so please let me know anything that should be updated to fit in with the current code standards!
Asana task 🎟️
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.