Merged
Conversation
nywilken
approved these changes
Apr 16, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
LGTM - after the release lets add the upgrade notes section so folks know how to update.
Upgrading to this release may fail until you've applied one of the fixes documented in https://github.com/hashicorp/packer-plugin-sdk/issues/187#user-content-available-fixes. Consumers of the Packer plugin SDK require a replace directive within their plugin's go module file to point to a compatible version of go-cty.
The replace directive subject to change in future releases can be applied by running the packer-sdc fix sub-command to apply the replace directive to your plugin with a recommended version of the go-cty fork.
Plugins already working with Packer Plugin SDK v0.5.2 are advised to apply the updated SDK fixes by re-running `packer-sdc fix` against the plugin's root directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.