Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/packer-plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.1
Choose a base ref
...
head repository: hashicorp/packer-plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.2
Choose a head ref
  • 12 commits
  • 17 files changed
  • 6 contributors

Commits on Jul 28, 2022

  1. Configuration menu
    Copy the full SHA
    f6affad View commit details
    Browse the repository at this point in the history
  2. v0.3.1 [skip ci]

    lbajolet-hashicorp committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4afde5d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Remove release script in favor of goreleaser (#118)

    Wilken Rivera authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    80d2587 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Update Xcode version for Darwin test builds (#122)

    Support for Xcode 12.0.0 has been deprecated on CircleCI. This change
    updates the build configuration to use the latest stable Xcode version
    available.
    
    While testing it was found that the build steps were actually downloading an older
    version of Go 1.17 and not the expected latest version. This change explicitly
    sets the version of Go to be used for test builds.
    
    There has to be a better wait to do this so we may look to replace this
    config at a future time.
    Wilken Rivera authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    762ec6e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Configuration menu
    Copy the full SHA
    62ac7b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Configuration menu
    Copy the full SHA
    42da5e2 View commit details
    Browse the repository at this point in the history
  2. ssh: make ssh bastion error message more precise

    When running a config that specifies a SSH communicator with a bastion
    without any authentication option, the proposed resolution would only
    include password or private key, and left agent authentication out of
    the error message.
    
    This commit adds it to the list of options to resolve it.
    lbajolet-hashicorp committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    28533d7 View commit details
    Browse the repository at this point in the history
  3. ssh: add more logging when connecting with bastion

    When a SSH bastion is used for connecting to a target, the operation is
    done completely silently, making it hard to understand if it is working
    as intended.
    
    To make it easier to follow the path that the command is taking, we add
    a few more INFO/DEBUG logs that parrot the actions it takes for
    connecting.
    lbajolet-hashicorp committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ad89271 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. sdk: Bump SDK to Go 1.18 (#121)

    * Update version of golangci-lint for Go1.18
    
    The pinned version of golangci-lint was out of date and failing when
    running with Go 1.18. This changes bumps the version to use the latest
    version.
    Wilken Rivera authored Aug 19, 2022
    Configuration menu
    Copy the full SHA
    2d9e9f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Fix support for forward slashes in cd_files for Windows (#115)

    Packer recommends that we use "/" as the path separator. There is a
    problem with using it on Windows because of the following behaviour:
    
    We might pass paths with forward slashes in `StepCreateCD` struct
    
    The string `rootFolder, err := tmp.Dir("packer_to_cdrom")` makes
    rootFolder use system-based slashes, which is "\" for Windows.
    
    This rootFolder is passed to `s.AddFile(rootFolder, toAdd)`
    
    And a mix of two slashes ruins our replace logic while going through
    the `visit` function. We end up having different slashes for `allDirs`
    and `discardPath` in
    `intermediaryDirs := strings.Replace(allDirs, discardPath, "", 1)`
    
    We change our replace login to don't depend on slashes.
    
    The tests we had didn't cover such cases as we passed all files with
    paths constructed with filepath.Join(dir, fname) which returns paths
    with "\\" on Windows. So we added a test case to specifically check
    forward slashes.
    tempora-mutantur authored Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f0d8f56 View commit details
    Browse the repository at this point in the history
  2. Provision SSHPublicKey while use custom SSH Private key (#101)

    * Provision SSHPublicKey while use custom SSH Private key
    
    * Add tests
    GennadySpb authored Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ae46818 View commit details
    Browse the repository at this point in the history
  3. Update release version v0.3.2 (#129)

    Bump version in preparation for the 0.3.2 release
    Wilken Rivera authored Sep 12, 2022
    Configuration menu
    Copy the full SHA
    7f67d2c View commit details
    Browse the repository at this point in the history
Loading