Use keypair from StepSSHKeyGen instead of Nova-generated keys#60
Conversation
Closes hashicorp#54 Since openstack's nova api can only generates RSA Keys, but let us upload other algorithms such as ed25519
|
|
| // Work around for https://github.com/hashicorp/packer/issues/2526 | ||
| func berToDer(ber []byte, ui packersdk.Ui) []byte { |
There was a problem hiding this comment.
Looking at the linked issue on why this was added and seeing that the Openstack API is not the one creating the SSH key this workaround is no longer necessary, correct?
There was a problem hiding this comment.
Indeed, since openstack api can only generate ssh-rsa keys or x509. The go api let us push already existing keypairs https://github.com/gophercloud/gophercloud/blob/master/openstack/compute/v2/extensions/keypairs/requests.go#L89
The api doesn't even return content of the uploaded key then we do not parse openstack keys anymore
There was a problem hiding this comment.
Great thanks for the quick response.
nywilken
left a comment
There was a problem hiding this comment.
The changes look good to me. I have a question about the deleted code that I would like for you to confirm before we merge. That said, we will bump the minor version for the next release to denote there is a change that folks should look into before using the latest version.
|
This documentation needs to be updated but that can be done in a separate PR. |
Closes #54
Since openstack's nova api can only generates RSA Keys, but let us upload other algorithms such as ed25519.