Skip to content

Revert "Merge pull request #9040 from hashicorp/powershell-exit-code-fix-4916"#9385

Merged
SwampDragons merged 1 commit intomasterfrom
revert-powershell-error-handler-9040
Jun 9, 2020
Merged

Revert "Merge pull request #9040 from hashicorp/powershell-exit-code-fix-4916"#9385
SwampDragons merged 1 commit intomasterfrom
revert-powershell-error-handler-9040

Conversation

@nywilken
Copy link
Copy Markdown
Contributor

@nywilken nywilken commented Jun 9, 2020

This reverts commit 334f399, reversing
changes made to 45a5d28.

When testing against Windows SSH the Powershell script fails to parse
the newly added if statement.

Relates to #4916
Relates to #9161

@nywilken
Revert "Merge pull request #9040 from hashicorp/powershell-exit-code-…
d72173a 
…fix-4916"

This reverts commit 334f399, reversing
changes made to 45a5d28.

When testing against Windows SSH the Powershell script fails to parse
the newly added if statement.
@nywilken nywilken requested a review from a team as a code owner June 9, 2020 15:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #9385 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
provisioner/powershell/provisioner.go 75.21% <100.00%> (-0.08%) ⬇️
packer/rpc/server.go 90.90% <0.00%> (-4.55%) ⬇️
packer/rpc/mux_broker.go 61.32% <0.00%> (-3.78%) ⬇️
packer/communicator.go 74.46% <0.00%> (-1.07%) ⬇️
builder/vmware/common/driver_parser.go 50.52% <0.00%> (-0.80%) ⬇️

@SwampDragons SwampDragons merged commit 4f8e4b6 into master Jun 9, 2020
@SwampDragons SwampDragons deleted the revert-powershell-error-handler-9040 branch June 9, 2020 16:21
@nywilken nywilken added tech-debt Issues and pull requests related to addressing technical debt or improving the codebase and removed tech-debt Issues and pull requests related to addressing technical debt or improving the codebase labels Jun 9, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@SwampDragons SwampDragons SwampDragons approved these changes

@azr azr azr approved these changes

@sylviamoss sylviamoss sylviamoss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tech-debt Issues and pull requests related to addressing technical debt or improving the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nywilken @SwampDragons @azr @sylviamoss