Skip to content

disk_size should not be required if storage is defined#8975

Merged
SwampDragons merged 1 commit intohashicorp:masterfrom
jhawk28:vsphereiso_disksize_fix
Mar 31, 2020
Merged

disk_size should not be required if storage is defined#8975
SwampDragons merged 1 commit intohashicorp:masterfrom
jhawk28:vsphereiso_disksize_fix

Conversation

@jhawk28
Copy link
Copy Markdown
Contributor

@jhawk28 jhawk28 commented Mar 31, 2020

added an error check for the storage.disk_size

Copy link
Copy Markdown

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing the code! 🙇

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2020

Codecov Report

Merging #8975 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
builder/vsphere/iso/step_create.go 0.00% <0.00%> (ø)
packer/communicator.go 75.53% <0.00%> (-1.07%) ⬇️
packer/plugin/client.go 79.91% <0.00%> (-0.45%) ⬇️

@SwampDragons SwampDragons merged commit fc911f0 into hashicorp:master Mar 31, 2020
@SwampDragons
Copy link
Copy Markdown
Contributor

Thanks!

@SwampDragons SwampDragons added this to the 1.5.6 milestone Apr 3, 2020
@jhawk28 jhawk28 deleted the vsphereiso_disksize_fix branch April 14, 2020 02:42
@ghost
Copy link
Copy Markdown

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants