Skip to content

WIP googlecompute: Use "ssh-keys" metadata rather than deprecated "sshKeys"#6445

Closed
tmshn wants to merge 1 commit intohashicorp:masterfrom
tmshn:google-fix-ssh-keys-metadata
Closed

WIP googlecompute: Use "ssh-keys" metadata rather than deprecated "sshKeys"#6445
tmshn wants to merge 1 commit intohashicorp:masterfrom
tmshn:google-fix-ssh-keys-metadata

Conversation

@tmshn
Copy link
Copy Markdown

@tmshn tmshn commented Jul 2, 2018

As written in the official document, metadata key "sshKeys" is deprecated and replaced by "ssh-keys".

Note: Setting the sshKeys metadata value on project metadata is deprecated. Use the ssh-keys metadata value instead. You might need to update the guest environment in instances using older images.

https://cloud.google.com/compute/docs/instances/adding-removing-ssh-keys?hl=en#project-wide

With this modification, project-wide SSH keys are now allowed, and the already-closed issue #6201 is actually fixed.

If (...snip...) or has a deprecated instance-only sshKeys value, the instance will ignore all project-wide SSH keys. To apply project-wide keys to an instance, make sure (...snip...) and, if present, remove the deprecated instance-only sshKeys value from instance metadata.

@tmshn tmshn requested a review from a team as a code owner July 2, 2018 12:24
@SwampDragons
Copy link
Copy Markdown
Contributor

This breaks my very simple test build... this may be too backwards-incompatible to merge.

{
  "builders": [
    {
      "type": "googlecompute",
      "account_file": "./myproject.json",
      "project_id": "myprojectid",
      "zone": "us-central1-a",
      "source_image": "debian-7-wheezy-v20150127",
      "ssh_username": "root"
    }
  ]
}

@rickard-von-essen rickard-von-essen changed the title [builder/google] Use "ssh-keys" metadata rather than deprecated "sshKeys" googlecompute: Use "ssh-keys" metadata rather than deprecated "sshKeys" Aug 16, 2018
@rickard-von-essen
Copy link
Copy Markdown
Contributor

It would be great to get this in, but we need to resolve why it breaks the test.

@tmshn
Copy link
Copy Markdown
Author

tmshn commented Aug 16, 2018

Sorry to be inactive so long. I was trying to figure out the problem, but couldn't yet.
Let me mark this as wip.

@tmshn tmshn changed the title googlecompute: Use "ssh-keys" metadata rather than deprecated "sshKeys" WIP googlecompute: Use "ssh-keys" metadata rather than deprecated "sshKeys" Aug 16, 2018
@SwampDragons
Copy link
Copy Markdown
Contributor

I'm going to close this for now since it doesn't seem like it's being actively worked on; if you get a chance to figure out the problem, just open a new one :) . Thanks!

@ghost
Copy link
Copy Markdown

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants