Backport of consul: add client configuration for grpc_ca_file into release/1.2.x#15752
Merged
shoenig merged 1 commit intorelease/1.2.xfrom Jan 11, 2023
Merged
Conversation
3425341 to
ed73657
Compare
a03d05f to
f768c80
Compare
f768c80 to
4026a7b
Compare
* [no ci] first pass at plumbing grpc_ca_file * consul: add support for grpc_ca_file for tls grpc connections in consul 1.14+ This PR adds client config to Nomad for specifying consul.grpc_ca_file These changes combined with hashicorp/consul#15913 should finally enable Nomad users to upgrade to Consul 1.14+ and use tls grpc connections. * consul: add cl entgry for grpc_ca_file * docs: mention grpc_tls changes due to Consul 1.14
4026a7b to
fe9e9f4
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15701 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This combined with hashicorp/consul#15913 should be enough to get folks unblocked in upgrading to Consul 1.14 with TLS enabled and using Connect.
Unfortunately the breaking change on the Consul side combined with the new config required on the Nomad side implies the upgrade path for affected folks requires reconfiguration and restarting the Consul and Nomad agents together. Further, users who now specify a CA for grpc connections distinct from the Consul HTTP CA will need to drain each node of existing Connect services making use of the Envoy proxy - otherwise existing services will begin to fail to receive xDS config changes from Consul.
Note that Nomad users will also need to either configure
consul.grpc_addressto the 8503 default tls grpc port, or modify Consul config to listen to grpc tls on port 8502, e.g.in nomad.hcl
Closes #15360